Check for missing ZGW backend config in zgw_import_data command #1356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swrichards
force-pushed
the
handle-missing-config-zgw-import-command
branch
from
2a25179
to
79e264e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1356 +/- ##
========================================
Coverage 95.18% 95.18%
========================================
Files 1001 1001
Lines 37012 37025 +13
========================================
+ Hits 35231 35244 +13
Misses 1781 1781 ☔ View full report in Codecov by Sentry. |
pi-sigma
requested changes
Aug 19, 2024
Not having a ZGW backend configured is something that happens in the wild, and more broadly, it would be a good thing if the management command does not fail hard on a missing config (as now) but gracefully exits with an error message. Better reporting to users (including our Celery task wrapper for this command), and cuts down on false-positive Sentry pings.
swrichards
force-pushed
the
handle-missing-config-zgw-import-command
branch
from
79e264e
to
eb04350
Compare
pi-sigma
approved these changes
Aug 19, 2024
alextreme
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not having a ZGW backend configured is something that happens in the wild, and more broadly, it would be a good thing if the management command does not fail hard on a missing config (as now) but gracefully exits with an error message. Better reporting to users (including our Celery task wrapper for this command), and cuts down on false-positive Sentry pings.