Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement zgw natural key support #1351

Merged
merged 2 commits into from
Aug 15, 2024
Merged

Conversation

swrichards
Copy link
Contributor

This is a preliminary PR to support the ZGW import/export logic, which will rely on natural keys for (de)serialization.

@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 96.93878% with 3 lines in your changes missing coverage. Please review.

Project coverage is 95.12%. Comparing base (8f22d47) to head (a7d6097).

Files Patch % Lines
src/open_inwoner/openzaak/models.py 81.25% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1351   +/-   ##
========================================
  Coverage    95.11%   95.12%           
========================================
  Files          995      995           
  Lines        36472    36569   +97     
========================================
+ Hits         34692    34786   +94     
- Misses        1780     1783    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swrichards swrichards marked this pull request as ready for review August 15, 2024 09:00
src/open_inwoner/openzaak/models.py Show resolved Hide resolved
src/open_inwoner/openzaak/tests/test_models.py Outdated Show resolved Hide resolved
src/open_inwoner/openzaak/models.py Show resolved Hide resolved
src/open_inwoner/openzaak/tests/factories.py Show resolved Hide resolved
src/open_inwoner/openzaak/tests/factories.py Outdated Show resolved Hide resolved
@swrichards swrichards force-pushed the implement-zgw-natural-key-support branch from 083e498 to a7d6097 Compare August 15, 2024 12:56
@swrichards swrichards marked this pull request as draft August 15, 2024 12:58
@swrichards swrichards marked this pull request as ready for review August 15, 2024 13:18
@alextreme alextreme merged commit bc7fa1a into develop Aug 15, 2024
18 checks passed
@alextreme alextreme deleted the implement-zgw-natural-key-support branch August 15, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants