Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2563] Fix disable setup configuration #1344

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

pi-sigma
Copy link
Contributor

@pi-sigma pi-sigma commented Aug 12, 2024

  • Abort configuration for config_step if config_step_enable is set to False
  • Set config_step_enable for each config_step to False by default

Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/issue/2563

@pi-sigma pi-sigma force-pushed the issue/2563-setup-configuration branch from 3470ec1 to 57250a6 Compare August 12, 2024 13:54
@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.11%. Comparing base (fa1cea1) to head (66d68e8).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1344      +/-   ##
===========================================
+ Coverage    95.10%   95.11%   +0.01%     
===========================================
  Files          995      995              
  Lines        36353    36465     +112     
===========================================
+ Hits         34572    34684     +112     
  Misses        1781     1781              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi-sigma pi-sigma force-pushed the issue/2563-setup-configuration branch from 57250a6 to e9d2021 Compare August 13, 2024 09:12
    - set config_step_enable variables to False by default
    - skip configuration steps if config_step_enable var is
      not set to True
@pi-sigma pi-sigma force-pushed the issue/2563-setup-configuration branch from e9d2021 to 66d68e8 Compare August 13, 2024 09:30
@pi-sigma pi-sigma marked this pull request as ready for review August 13, 2024 09:56
@alextreme alextreme merged commit 8f22d47 into develop Aug 14, 2024
18 checks passed
@alextreme alextreme deleted the issue/2563-setup-configuration branch August 14, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants