Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2648] handle legacy case detail URLs with redirect #1333

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

swrichards
Copy link
Contributor

@swrichards swrichards commented Aug 5, 2024

The case detail URL now contains a reference to the
ZGW api group to be used to fetch the case. It is quite
likely there are various hard-coded URLs in the wild
(especially in notification emails) that point to the
old case detail URLs. This commit adds a redirect
handler for the now-deprecated case detail URL and
tries to handle the request gracefully, depending on
the case.

Taiga 2648.

@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 95.09%. Comparing base (1edaef7) to head (d8e6694).
Report is 4 commits behind head on develop.

Files Patch % Lines
src/open_inwoner/cms/cases/views/status.py 66.66% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1333   +/-   ##
========================================
  Coverage    95.09%   95.09%           
========================================
  Files          992      993    +1     
  Lines        36164    36219   +55     
========================================
+ Hits         34389    34443   +54     
- Misses        1775     1776    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swrichards swrichards force-pushed the tasks/2648-legacy-case-detail-url-redirect branch 2 times, most recently from 705b045 to 6f238e9 Compare August 5, 2024 14:00
@swrichards swrichards marked this pull request as ready for review August 5, 2024 14:00
@swrichards swrichards force-pushed the tasks/2648-legacy-case-detail-url-redirect branch 3 times, most recently from 3c80484 to f698c20 Compare August 5, 2024 15:06
The case detail URL now contains a reference to the
ZGW api group to be used to fetch the case. It is quite
likely there are various hard-coded URLs in the wild
(especially in notification emails) that point to the
old case detail URLs. This commit adds a redirect
handler for the now-deprecated case detail URL and
tries to handle the request gracefully, depending on
the case.
@swrichards swrichards force-pushed the tasks/2648-legacy-case-detail-url-redirect branch from f698c20 to d8e6694 Compare August 6, 2024 08:02
@alextreme alextreme merged commit 81fa5d6 into develop Aug 6, 2024
18 checks passed
@alextreme alextreme deleted the tasks/2648-legacy-case-detail-url-redirect branch August 6, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants