[#2645] Filter cases by status #1331
Conversation
pi-sigma
force-pushed
the
task/2645-case-filter-status
branch
from
4a30aed
to
7fc015f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1331 +/- ##
=========================================
Coverage 95.09% 95.09%
=========================================
Files 993 994 +1
Lines 36219 36325 +106
=========================================
+ Hits 34443 34544 +101
- Misses 1776 1781 +5 ☔ View full report in Codecov by Sentry. |
pi-sigma
force-pushed
the
task/2645-case-filter-status
branch
6 times, most recently
from
f15addc
to
dfc9876
Compare
| case_statuses = [case.zaak.status_text for case in cases] | ||
|
|
||
| # add static text for open submissions | ||
| case_statuses += ["Openstaande aanvraag" for submission in submissions] |
There was a problem hiding this comment.
Given that we use the Openstaande aanvraag literal below as well, we might want to put this in a constant, something like SUBMISSION_STATUS_OPEN.
I was also wondering: should we not also have the closed status, or do they disappear from the list?
There was a problem hiding this comment.
- I'll create the constant, makes sense
- My understanding is that open submissions turn into regular cases once they've been taken up by s.o. at the municipality, so they disappear from the list. We also have the hard-coded string in
src/open_inwoner/templates/pages/cases/list_inner.html
pi-sigma
force-pushed
the
task/2645-case-filter-status
branch
from
dfc9876
to
75e375c
Compare
| from .mixins import CaseAccessMixin, CaseLogMixin, OuterCaseAccessMixin | ||
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| SUBMISSION_STATUS_OPEN = _("Openstaande aanvraag") |
There was a problem hiding this comment.
Double checking: will this value also be translated in the submissions themselves?
There was a problem hiding this comment.
Translation in the template was indeed missing; I've added it.
There was a problem hiding this comment.
Ah I didn't even think of that, but 👍 .
I actually meant this snippet:
open_submissions = (
open_submissions if SUBMISSION_STATUS_OPEN in statuses else []
)I was concerned whether there is a situation where SUBMISSION_STATUS_OPEN is translated but statsuses is not.
There was a problem hiding this comment.
The statuses are retrieved in openzaak/api_models.py and indeed not translated, since we don't have control over what statuses are returned. We can translate the "status" for open submissions since it is our own. Do you think it would be better to leave it untranslated as well for consistency?
- retrieval of cases + open submissions is encapsulated
in a dedicated service class
- extract status_text processing of Zaak api model to
separate property
pi-sigma
force-pushed
the
task/2645-case-filter-status
branch
from
75e375c
to
0c8a157
Compare
Styling for the case filter form is rudimentary and should be improved in accordance with design (see https://taiga.maykinmedia.nl/project/open-inwoner/task/2650)
Taiga: https://github.com/maykinmedia/open-inwoner/pull/new/task/2645-case-filter-status