Avoid resolving zgw objects in contactmomenten client #1328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The immediate trigger for this is that passing a zaken_client to the objectcontactmomenten is fraught now we support multiple zgw backends: which backend do we pass to resolve the zaak? More generally: resolving does not belong in the API client, which should focus on fetching data from a service and returning it to the caller, which is a distinct concern from enriching the objects thus retrieved.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1328 +/- ##
===========================================
+ Coverage 95.09% 95.11% +0.02%
===========================================
Files 993 993
Lines 36184 36173 -11
===========================================
- Hits 34408 34407 -1
+ Misses 1776 1766 -10 ☔ View full report in Codecov by Sentry. |
pi-sigma
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The immediate trigger for this is that passing a zaken_client to the objectcontactmomenten is fraught now we support multiple zgw backends: which backend do we pass to resolve the zaak?
More generally: resolving does not belong in the API client, which should focus on fetching data from a service and returning it to the caller, which is a distinct concern from enriching the objects thus retrieved.