Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♿ [#2584] Refactor heading architecture (no flexbox) #1299

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

jiromaykin
Copy link
Contributor

@jiromaykin jiromaykin commented Jul 8, 2024

issue: https://taiga.maykinmedia.nl/project/open-inwoner/task/2584

for a correct screenreader order, interactive elements should not be inside a Heading element.

Connected to PR maykinmedia/open-inwoner-design-tokens#10

Since design-tokens have been updated: $ npm ci --legacy-peer-deps
and $ npm run build

Screenshot 2024-07-11 at 14 07 23

@jiromaykin jiromaykin changed the title ♿ [#2584] first commit header architecture ♿ [#2584] Refactor heading architecture (no flexbox) Jul 8, 2024
@jiromaykin jiromaykin force-pushed the issue/2584-A11y-heading-architecture branch from 4820009 to 44b02a6 Compare July 9, 2024 09:42
@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.13%. Comparing base (8f65345) to head (f109a4a).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1299   +/-   ##
========================================
  Coverage    95.13%   95.13%           
========================================
  Files          983      983           
  Lines        35847    35847           
========================================
  Hits         34104    34104           
  Misses        1743     1743           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jiromaykin jiromaykin added the Accessibility Improving accessibility label Jul 9, 2024
@jiromaykin jiromaykin force-pushed the issue/2584-A11y-heading-architecture branch from ba0da1c to f109a4a Compare July 11, 2024 11:05
@jiromaykin jiromaykin marked this pull request as ready for review July 11, 2024 12:06
@jiromaykin jiromaykin requested a review from pi-sigma July 11, 2024 12:08
@jiromaykin jiromaykin merged commit 9c33cde into develop Jul 16, 2024
18 checks passed
@jiromaykin jiromaykin deleted the issue/2584-A11y-heading-architecture branch July 16, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Improving accessibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants