[#2605] Use NLDS classes for uitkeringen PDF styling #1298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi-sigma
force-pushed
the
issue/2605-uitkeringen-pdf-font
branch
from
3c91db6
to
c1b786f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1298 +/- ##
========================================
Coverage 95.13% 95.13%
========================================
Files 983 983
Lines 35847 35847
========================================
Hits 34104 34104
Misses 1743 1743 ☔ View full report in Codecov by Sentry. |
jiromaykin
reviewed
Jul 8, 2024
| @@ -15,6 +15,7 @@ | |||
|
|
|||
| .yearly-report__p, | |||
| .yearly-report__td { | |||
| font-family: utrecht-paragraph; | |||
There was a problem hiding this comment.
font-family: utrecht-paragraph; will never work because "utrecht-paragraph" is an HTML CLASS.
So this is not CSS.
If this would be an NLDS project file, then the correct variable would be var(--utrecht-document-font-family) which eventually cascades to the end-value 'Body' font-family, but it is not an NLDS page , so i will revert all of these values and add more for the headings.
jiromaykin
approved these changes
Jul 9, 2024
pi-sigma
force-pushed
the
issue/2605-uitkeringen-pdf-font
branch
from
034e76a
to
2e08903
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taiga: #2605