Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♿ [#2583] Make control of modal focusable in the right order #1287

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

jiromaykin
Copy link
Contributor

@jiromaykin jiromaykin commented Jul 1, 2024

issue: https://taiga.maykinmedia.nl/project/open-inwoner/us/2402

  1. accessibility requirement "When a dialog closes, focus returns to the element that invoked the dialog"
  2. making sure the Escape button doesn't interfere with closing of the navigation etc.
  3. moving the KCM feedback button to bottom of footer for more logical Tab order

Effect:
after closing a modal your Tab focus should land on the button that opened it, meaning you can Tab backward or forward starting from the modal-opening-control button.

clickmodalfocus

@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.13%. Comparing base (318aed7) to head (591d276).
Report is 36 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #1287       +/-   ##
============================================
+ Coverage    44.22%   95.13%   +50.90%     
============================================
  Files          972      983       +11     
  Lines        35571    35847      +276     
============================================
+ Hits         15733    34104    +18371     
+ Misses       19838     1743    -18095     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jiromaykin jiromaykin added the Accessibility Improving accessibility label Jul 1, 2024
@jiromaykin jiromaykin changed the title [#2583] Make modal focusable in the right order ♿ [#2583] Make modal focusable in the right order Jul 1, 2024
@jiromaykin jiromaykin changed the title ♿ [#2583] Make modal focusable in the right order ♿ [#2583] Make control of modal focusable in the right order Jul 8, 2024
@jiromaykin jiromaykin force-pushed the issue/2583-A11y-focus-control-modals branch from f7272f6 to 5c1b8ce Compare July 8, 2024 09:23
@jiromaykin jiromaykin marked this pull request as ready for review July 8, 2024 09:27
@jiromaykin jiromaykin requested a review from pi-sigma July 8, 2024 10:52
@jiromaykin jiromaykin force-pushed the issue/2583-A11y-focus-control-modals branch from 5f699a8 to 10e006f Compare July 9, 2024 09:10
@jiromaykin jiromaykin force-pushed the issue/2583-A11y-focus-control-modals branch from 10e006f to 591d276 Compare July 9, 2024 09:10
@jiromaykin jiromaykin requested a review from pi-sigma July 9, 2024 09:37
@alextreme alextreme merged commit 8ab98dd into develop Jul 11, 2024
18 checks passed
@alextreme alextreme deleted the issue/2583-A11y-focus-control-modals branch July 11, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Improving accessibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants