Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2570] Add multi-backend support to ZGW iotypes importer #1284

Merged
merged 3 commits into from
Jul 3, 2024

Conversation

swrichards
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 7.95455% with 81 lines in your changes missing coverage. Please review.

Project coverage is 44.23%. Comparing base (b6ffbed) to head (a113ac1).
Report is 4 commits behind head on develop.

Files Patch % Lines
...inwoner/openzaak/tests/test_zgw_imports_iotypes.py 5.45% 52 Missing ⚠️
...inwoner/openzaak/tests/test_zgw_imports_command.py 5.55% 17 Missing ⚠️
src/open_inwoner/openzaak/models.py 27.27% 8 Missing ⚠️
src/open_inwoner/openzaak/zgw_imports.py 0.00% 3 Missing ⚠️
src/open_inwoner/openzaak/admin.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1284      +/-   ##
===========================================
- Coverage    44.24%   44.23%   -0.01%     
===========================================
  Files          972      973       +1     
  Lines        35577    35594      +17     
===========================================
+ Hits         15740    15746       +6     
- Misses       19837    19848      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swrichards swrichards changed the title Add multi-backend support to ZGW iotypes importer [#2570] Add multi-backend support to ZGW iotypes importer Jun 27, 2024
@swrichards swrichards force-pushed the tasks/2570-import-iotypes-with-multi-zgw-backend branch from 72d6a84 to 609b172 Compare July 1, 2024 16:09
@swrichards swrichards marked this pull request as ready for review July 1, 2024 16:10
@swrichards swrichards requested a review from pi-sigma July 2, 2024 08:52
Copy link
Contributor

@pi-sigma pi-sigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. One small question/suggestion about the messages, though not sure if it's feasible.

AAA - zaaktype-aaa
BBB - zaaktype-bbb
BBB - zaaktype-bbb
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we distinguish between these configs as in the case of the catalogi messages above (e.g. by displaying the netloc of the service api root or something else)?. It's quite useful in the catalogus case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point, added the catalogus base url across the objects: see what you think.

@swrichards swrichards force-pushed the tasks/2570-import-iotypes-with-multi-zgw-backend branch from 609b172 to 0b8692b Compare July 2, 2024 14:56
@swrichards swrichards force-pushed the tasks/2570-import-iotypes-with-multi-zgw-backend branch from 0b8692b to a113ac1 Compare July 2, 2024 15:29
@swrichards swrichards requested a review from pi-sigma July 2, 2024 15:58
@swrichards swrichards requested a review from alextreme July 3, 2024 08:28
@alextreme alextreme merged commit abc196e into develop Jul 3, 2024
17 checks passed
@alextreme alextreme deleted the tasks/2570-import-iotypes-with-multi-zgw-backend branch July 3, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants