[#2589] Run CI tests in parallel #1282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1282 +/- ##
============================================
- Coverage 95.17% 44.23% -50.94%
============================================
Files 981 971 -10
Lines 35665 35453 -212
============================================
- Hits 33945 15684 -18261
- Misses 1720 19769 +18049 ☔ View full report in Codecov by Sentry. |
swrichards
force-pushed
the
issues/2589-parallel-test-execution
branch
from
60a21db
to
c95919e
Compare
We have made several previous attempts at running the CI tests in parallel, which were ultimately reverted because we ran into the issue described at django/django#17650 and https://code.djangoproject.com/ticket/32114 (in this repo, see PRs 1050, 948 and 690. The Django ticket has been fixed, but will will only be included in 5.1 onwards, and won't be backported to 4.2.x. However, it seems the current testsuite no longer fails with the issue reported in the Django ticket (pickle related errors). It is possible the potentially failing tests are flaky, but so far we've not run into it during a handful of parallel runs. This commit will re-enable parallel tests, and we'll have to see if we run into the same issues again.
swrichards
force-pushed
the
issues/2589-parallel-test-execution
branch
from
c95919e
to
c7f44f8
Compare
alextreme
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have made several previous attempts at running the CI tests in
parallel, which were ultimately reverted because we ran into the
issue described at django/django#17650 and
https://code.djangoproject.com/ticket/32114 (in this repo, see PRs
#1050, #948 and #690.
The Django ticket has been fixed, but will will only be included
in 5.1 onwards, and won't be backported to 4.2.x. However, it seems
the current testsuite no longer fails with the issue reported in the
Django ticket (pickle related errors). It is possible the potentially
failing tests are flaky, but so far we've not run into it during a
handful of parallel runs. This commit will re-enable parallel tests,
and we'll have to see if we run into the same issues again.