💄 [#2311] Set feedback border-color #1158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1158 +/- ##
========================================
Coverage 95.21% 95.21%
========================================
Files 1005 1005
Lines 37185 37185
========================================
Hits 35404 35404
Misses 1781 1781 ☔ View full report in Codecov by Sentry. |
jiromaykin
changed the title
jiromaykin
force-pushed
the
feature/2311-feedback-button-border-white
branch
from
0d6af07
to
05f4a07
Compare
jiromaykin
changed the title
jiromaykin
force-pushed
the
feature/2311-feedback-button-border-white
branch
from
489de34
to
6d11630
Compare
jiromaykin
force-pushed
the
feature/2311-feedback-button-border-white
branch
from
6d11630
to
b73042c
Compare
jiromaykin
changed the title
jiromaykin
force-pushed
the
feature/2311-feedback-button-border-white
branch
3 times, most recently
from
2570c42
to
d013b9e
Compare
jiromaykin
force-pushed
the
feature/2311-feedback-button-border-white
branch
from
d013b9e
to
2d1b1a9
Compare
jiromaykin
force-pushed
the
feature/2311-feedback-button-border-white
branch
from
2d1b1a9
to
1dd0678
Compare
pi-sigma
approved these changes
Aug 27, 2024
|
🙈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After much discusion the decision is made to set the borders equally and use the info-colors.
Perhaps later a decision will be made to use different colors.
Latest updated issue: https://taiga.maykinmedia.nl/project/open-inwoner/issue/2427
Closed color-issue: https://taiga.maykinmedia.nl/project/open-inwoner/issue/2430
Design: https://www.figma.com/file/iKGhWhstaLIlFSaND2q7cE/OIP---Designs-(new)?node-id=2509%3A6766&mode=dev
old issue: https://taiga.maykinmedia.nl/project/open-inwoner/task/2311