Refactor bbinfo file to be an advanced feature not enabled by default. #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As brought up here: #25
The branch info file has honestly been a rabbit hole I went down. The original idea was to have a solution solving the use case of having custom backup branch names. "If we don't have a config file, how will the extension know?" This lead to the branch info file, and then in order to make the branch info file work, I kept needing to add more and more jank settings, like
shouldCommitBranchInfoFile, #20 , #22 , etc. After taking a step back from active development, it became embarrassingly obvious how hard to use and confusing this file was.Instead, make the default behavior backup any branch
Atogbs-backup-A. This should be enough for 99% of the users. For the remaining 1%, they can still enable the branch info file as an advanced setting.