Fix number of mirrors, fixes cta-observatory#1057

maxnoe · Apr 25, 2019 · 7168956 · 7168956
1 parent b5c9913
commit 7168956
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/ctapipe/io/simteleventsource.py b/ctapipe/io/simteleventsource.py
@@ -112,7 +112,7 @@ def prepare_subarray_info(self, telescope_descriptions, header):
 
             optics = OpticsDescription(
                 name=telescope.name,
-                num_mirrors=cam_settings['n_mirrors'],
+                num_mirrors=telescope.n_mirrors,
                 equivalent_focal_length=focal_length,
                 mirror_area=u.Quantity(cam_settings['mirror_area'], u.m**2),
                 num_mirror_tiles=cam_settings['n_mirrors'],

diff --git a/ctapipe/io/tests/test_simteleventsource.py b/ctapipe/io/tests/test_simteleventsource.py
@@ -203,3 +203,11 @@ def test_camera_caching():
     event = next(iter(source))
     subarray = event.inst.subarray
     assert subarray.tel[1].camera is subarray.tel[2].camera
+
+
+def test_instrument():
+    '''Test if same telescope types share a single instance of CameraGeometry'''
+    source = SimTelEventSource(input_url=gamma_test_large_path)
+    event = next(iter(source))
+    subarray = event.inst.subarray
+    assert subarray.tel[1].optics.num_mirrors == 1