Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MMDB_LIB_VERSION #90

Closed
wants to merge 2 commits into from
Closed

Conversation

remicollet
Copy link
Contributor

Digging why test suite fail on old RHEL / CentOS 6

+ php --define extension=/builddir/build/BUILDROOT/php-maxminddb-1.5.0-1.el6.remi17.0.x86_64/usr/lib64/php/modules/maxminddb.so /usr/bin/phpunit --bootstrap /builddir/build/BUILDROOT/php-maxminddb-1.5.0-1.el6.remi17.0.x86_64/usr/share/php/MaxMind/Db/Reader/autoload.php --verbose
PHPUnit 5.7.27 by Sebastian Bergmann and contributors.
Runtime:       PHP 7.0.33
Configuration: /builddir/build/BUILD/MaxMind-DB-Reader-php-bd436094fc0a9b0558a899fb80b0ae34fe1808a0/phpunit.xml.dist
....................F................                             37 / 37 (100%)
Time: 39 ms, Memory: 13.00MB
There was 1 failure:
1) MaxMind\Db\Test\Reader\ReaderTest::testV6AddressV4Database
Failed asserting that exception of type "\InvalidArgumentException" is thrown.
FAILURES!
Tests: 37, Assertions: 363, Failures: 1.

I found this is related to libmaxmindb 1.1.1 in EPEL
https://apps.fedoraproject.org/packages/libmaxminddb

This PR simply expose the MaxMind\\Db\\Reader::MMDB_LIB_VERSION to userland, and thus allow to skip this test (can probably be use later for future change in the library).

@oschwald
Copy link
Member

oschwald commented Oct 1, 2019

Thanks! I merged from the command line.

@oschwald oschwald closed this Oct 1, 2019
@remicollet remicollet deleted the issue-lilbver branch October 1, 2019 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants