Remove development stuff from releases #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,6 @@ | |||
| /dev-bin/ export-ignore | |||
| /examples/ export-ignore | |||
| /ext/ export-ignore | |||
|
Should /ext/tests be included or not? |
|
We should probably leave that. It is just a basic sanity test that gets run after the extension is built. |
|
If you wanted, you could exclude |
Done |
|
Thanks! |
|
👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
composer requirecurrently downloads all the contents of the repository, but for production usage the development stuff is not required (and it could may be harmful if it contains executable files).What about removing this development stuff from releases?
This affects only installing releases: git-cloning is not touched, so that people that want to run tests/build phars can perform a
git clone