-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config.w32 for building on Windows #115
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I had a couple of small comments. Also please add the file to package.xml
so that it ends up in the PECL package.
There is another thing needed to make it compile under PHP 7.4 and PHP 8.0. php/php-src@86aac3e: uint does not exist anymore in the Windows environment. Usually it is replaced by uint32_t. e.g. php/php-src@afb6ca2 Shall I make that change in the same PR? |
@cmb69 The dependencies are in https://github.com/maxmind/libmaxminddb
The last two lines are specific for my build environment, but you'll get the grip. |
|
The best way forward would be to make a new release of libmaxminddb with the commit that prevents getopt: maxmind/libmaxminddb@73f1236 And then make a new release of the PHP maxminddb extension with support for Windows. |
Yes, I think it would make sense to do a release of |
Releases of both this and |
This is a minimal config.w32 for building php_maxminddb.dll on Windows.
Tests with a GeoIP2-City.mmdb in \usr\local\share\GeoIP
It works for PHP 7.0 - 7.4 and PHP 8.0, provided the libmaxminddb dependencies are in deps/lib and deps/include. Please review and merge.
See a phpinfo dump:
https://phpdev.toolsforresearch.com/php-8.0.1RC1-nts-Win32-vs16-x64.htm
And the complete distro
https://phpdev.toolsforresearch.com/php-8.0.1RC1-nts-Win32-vs16-x64.zip