Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extension does not care about open_basedir #61

Closed
bburnichon opened this issue Feb 8, 2018 · 2 comments
Closed

extension does not care about open_basedir #61

bburnichon opened this issue Feb 8, 2018 · 2 comments

Comments

@bburnichon
Copy link

if (0 != access(db_file, R_OK)) {

Access is a very low level file operation. Not all low level accesses to database files should be authorized.
Going from Userland php to extension is no issue, but the reverse could cause some open_basedir errors. Database path could be passed from userland (so can sometimes be accessed by attackers) so internal path access php checks are mandatory.

@oschwald
Copy link
Member

Thanks for raising this. We will look into it.

oschwald added a commit that referenced this issue Feb 21, 2018
oschwald added a commit that referenced this issue Feb 21, 2018
@rafl rafl closed this as completed in 3313ee8 Feb 21, 2018
@bburnichon
Copy link
Author

Thanks for fixing this and released a new version!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants