You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Love that you guys package a great client lib. Thanks for the hard work.
One thing that would be useful would be including the insights methods on GeoIp2Provider, or another interface; this makes providing a test double for insights much more easily, as you don't have to wrap WebServiceClient to return a predictable response. We prefer to do this to avoid introducing the complexity of mocking frameworks.
Thanks!
Evan
The text was updated successfully, but these errors were encountered:
GeoIp2Provider provider is implemented by bothe the database reader and web service client. The former doesn't have an equivalent to Insights. However, it would make sense to add a WebServiceProvider given that we already have DatabaseProvider for the database reader.
Love that you guys package a great client lib. Thanks for the hard work.
One thing that would be useful would be including the insights methods on GeoIp2Provider, or another interface; this makes providing a test double for insights much more easily, as you don't have to wrap WebServiceClient to return a predictable response. We prefer to do this to avoid introducing the complexity of mocking frameworks.
Thanks!
Evan
The text was updated successfully, but these errors were encountered: