Improve code readability

Signed-off-by: Maximilian Löffler <[email protected]>
maxloeffler · Nov 21, 2023 · 5d3dd57 · 5d3dd57
1 parent bb5aeb2
commit 5d3dd57
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/util-split.R b/util-split.R
@@ -67,7 +67,7 @@ split.data.time.based = function(project.data, time.period = "3 months", bins =
 
     # validate existence and type of the 'bins' parameter
     if (!is.null(bins) && !lubridate::is.POSIXct(bins)) {
-        dates = parallel::mclapply(bins, function(bin) get.date.from.string(bin))
+        dates = parallel::mclapply(bins, get.date.from.string)
         if (any(is.na(dates))) {
             logging::logerror("The bins parameter, if present, needs to be a character representing a date")
             stop("Stopped due to incorrect parameter types")
@@ -105,12 +105,12 @@ split.data.by.bins = function(project.data, activity.amount, bins, split.basis =
     }
 
     # validate existence and type of the 'bins' component of the 'bins' parameter
-    if (!"bins" %in% names(bins)) {
+    if (!("bins" %in% names(bins))) {
         logging::logerror("The 'bins' parameter needs to include a component 'bins'")
         stop("Stopped due to incorrect parameter types")
     }
 
-    dates = parallel::mclapply(bins[["bins"]], function(bin) get.date.from.string(bin))
+    dates = parallel::mclapply(bins[["bins"]], get.date.from.string)
     if (any(is.na(dates))) {
         logging::logerror("The 'bins' component of the bins parameter needs to be a character representing a date")
         stop("Stopped due to incorrect parameter types")