This repository has been archived by the owner on Apr 10, 2023. It is now read-only.
Newcard/maestro #12
Open
Newcard/maestro #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 13, 2016 14:38
|
HI, How do I go about fixing the issue reported by the CI? |
|
@gauravkeshre ignore it - I switched from travis to circle a while ago. It looks like the integration hasn't been disabled. Thanks for your work! |
|
@gauravkeshre please can you also add some tests - adding a few fake maestro cards to the plist will suffice. Sorry the response is so late - I haven't been on this account much as of recent! |
maxkramer
suggested changes
Mar 11, 2017
| @@ -15,6 +15,7 @@ typedef NS_ENUM(NSInteger, OLCreditCardType) { | |||
| OLCreditCardTypeDiscover, | |||
| OLCreditCardTypeDinersClub, | |||
| OLCreditCardTypeJCB, | |||
| OLCreditCardTypeMAESTRO, | |||
There was a problem hiding this comment.
Maestro should be spelt accordingly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a regex to validate MAESTRO card
^(5018|5020|5038|6304|6759|676[1-3]|6220)[0-9]{12}([0-9]{2}|[0-9]{3}|[0-9]{0})$Eg:
6763269232330618
5038188028168894222