Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sca info when using credit card for paypal rtau #229

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

MiguelGomezMaxio
Copy link

@MiguelGomezMaxio MiguelGomezMaxio commented Sep 10, 2024

This PR solves PAYM-1558

  • It adds the SCA indicators for triggering Paypal's RTAU

@MiguelGomezMaxio MiguelGomezMaxio self-assigned this Sep 10, 2024
@himn1
Copy link

himn1 commented Sep 18, 2024

Hmm this PR https://github.com/maxio-com/chargify/pull/24752 does not use this branch.
Should it?
I wonder where are tests?
It could be tested by AB but this branch would have to be used by another AB branch.
It is "dangling" currently.

@MiguelGomezMaxio
Copy link
Author

Hmm this PR maxio-com/chargify#24752 does not use this branch. Should it? I wonder where are tests? It could be tested by AB but this branch would have to be used by another AB branch. It is "dangling" currently.

You're absolutely right. I have already updated the CH PR to use this branch in its Gemfile

himn1
himn1 previously approved these changes Sep 19, 2024
@MiguelGomezMaxio MiguelGomezMaxio requested a review from himn1 October 2, 2024 11:10
@MiguelGomezMaxio MiguelGomezMaxio merged commit bdc3248 into master Oct 2, 2024
@himn1 himn1 deleted the PAYM-1558-add-paypal-rtau-integration branch October 3, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants