Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @maxinminax, I'm located in the EU and I've recently purchased a few Xiaomi smart home devices. While testing the NPM package, I found a couple of issues that I believe are the result of my Mi Account region settings (DE):
viomi.vacuum.v7
, multiple properties (defined in the device class) weren't available, I believe it's better to have a soft check for the length of the properties rather than throwing an invisible error.Please let me know if there's anything I should change and/or improve, I'd be happy to contribute to the project on a regular basis.