forked from knative/client
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixes issue knative#111 by responding with an error for unknown subco…
…mmands ```bash ➜ client git:(issue111) ✗ ./kn service unknown Service command group Usage: kn service [flags] kn service [command] Available Commands: create Create a service. delete Delete a service. describe Describe available services. list List available services. update Update a service. Flags: -h, --help help for service Global Flags: --kubeconfig string kubectl config file (default is $HOME/.kube/config) Use "kn service [command] --help" for more information about a command. unknown command "unknown" for "kn service" ➜ client git:(issue111) ✗ ./kn revision lol Revision command group Usage: kn revision [flags] kn revision [command] Available Commands: describe Describe revisions. list List available revisions. Flags: -h, --help help for revision Global Flags: --kubeconfig string kubectl config file (default is $HOME/.kube/config) Use "kn revision [command] --help" for more information about a command. unknown command "lol" for "kn revision" ``` This works for both the `service` and `revision` groups whe called with empty and unknown sub-command.
1 parent
8a1d412
commit f27ed5c
Showing
7 changed files
with
166 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,6 +6,10 @@ Revision command group | |
|
||
Revision command group | ||
|
||
``` | ||
kn revision [flags] | ||
``` | ||
|
||
### Options | ||
|
||
``` | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,6 +6,10 @@ Service command group | |
|
||
Service command group | ||
|
||
``` | ||
kn service [flags] | ||
``` | ||
|
||
### Options | ||
|
||
``` | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
// Copyright © 2018 The Knative Authors | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
package revision | ||
|
||
import ( | ||
"strings" | ||
"testing" | ||
|
||
"github.com/knative/client/pkg/kn/commands" | ||
v1alpha1 "github.com/knative/serving/pkg/apis/serving/v1alpha1" | ||
"k8s.io/apimachinery/pkg/runtime" | ||
client_testing "k8s.io/client-go/testing" | ||
) | ||
|
||
func fakeRevision(args []string, response *v1alpha1.ServiceList) (action client_testing.Action, output []string, err error) { | ||
knParams := &commands.KnParams{} | ||
cmd, fakeServing, buf := commands.CreateTestKnCommand(NewRevisionCommand(knParams), knParams) | ||
fakeServing.AddReactor("*", "*", | ||
func(a client_testing.Action) (bool, runtime.Object, error) { | ||
action = a | ||
return true, response, nil | ||
}) | ||
cmd.SetArgs(args) | ||
err = cmd.Execute() | ||
if err != nil { | ||
return | ||
} | ||
output = strings.Split(buf.String(), "\n") | ||
return | ||
} | ||
|
||
func TestUnknownSubcommand(t *testing.T) { | ||
_, _, err := fakeRevision([]string{"revision", "unknown"}, &v1alpha1.ServiceList{}) | ||
if err == nil { | ||
t.Error(err) | ||
return | ||
} | ||
|
||
if err.Error() != "unknown command \"unknown\" for \"kn revision\"" { | ||
t.Errorf("Bad error message '%s'", err.Error()) | ||
} | ||
} | ||
|
||
func TestEmptySubcommand(t *testing.T) { | ||
_, _, err := fakeRevision([]string{"revision"}, &v1alpha1.ServiceList{}) | ||
if err == nil { | ||
t.Error(err) | ||
return | ||
} | ||
|
||
if err.Error() != "please provide a valid sub-command for \"kn revision\"" { | ||
t.Errorf("Bad error message '%s'", err.Error()) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
// Copyright © 2018 The Knative Authors | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
package service | ||
|
||
import ( | ||
"strings" | ||
"testing" | ||
|
||
"github.com/knative/client/pkg/kn/commands" | ||
v1alpha1 "github.com/knative/serving/pkg/apis/serving/v1alpha1" | ||
"k8s.io/apimachinery/pkg/runtime" | ||
client_testing "k8s.io/client-go/testing" | ||
) | ||
|
||
func fakeService(args []string, response *v1alpha1.ServiceList) (action client_testing.Action, output []string, err error) { | ||
knParams := &commands.KnParams{} | ||
cmd, fakeServing, buf := commands.CreateTestKnCommand(NewServiceCommand(knParams), knParams) | ||
fakeServing.AddReactor("*", "*", | ||
func(a client_testing.Action) (bool, runtime.Object, error) { | ||
action = a | ||
return true, response, nil | ||
}) | ||
cmd.SetArgs(args) | ||
err = cmd.Execute() | ||
if err != nil { | ||
return | ||
} | ||
output = strings.Split(buf.String(), "\n") | ||
return | ||
} | ||
|
||
func TestUnknownSubcommand(t *testing.T) { | ||
_, _, err := fakeService([]string{"service", "unknown"}, &v1alpha1.ServiceList{}) | ||
if err == nil { | ||
t.Error(err) | ||
return | ||
} | ||
|
||
if err.Error() != "unknown command \"unknown\" for \"kn service\"" { | ||
t.Errorf("Bad error message '%s'", err.Error()) | ||
} | ||
} | ||
|
||
func TestEmptySubcommand(t *testing.T) { | ||
_, _, err := fakeService([]string{"service"}, &v1alpha1.ServiceList{}) | ||
if err == nil { | ||
t.Error(err) | ||
return | ||
} | ||
|
||
if err.Error() != "please provide a valid sub-command for \"kn service\"" { | ||
t.Errorf("Bad error message '%s'", err.Error()) | ||
} | ||
} |