Rebuild web client using npm, ts and vuejs #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO need to change for production
rydeom
reviewed
Dec 29, 2022
web/client/src/components/infrastructure/infrastructure-map.vue
Outdated
Show resolved
Hide resolved
rydeom
reviewed
Jan 3, 2023
rydeom
reviewed
Jan 3, 2023
web/client/src/components/golden-layout-components/SimulationComponent.vue
Outdated
Show resolved
Hide resolved
rydeom
reviewed
Jan 4, 2023
rydeom
reviewed
Jan 4, 2023
web/client/src/components/infrastructure/infrastructure-map.vue
Outdated
Show resolved
Hide resolved
rydeom
reviewed
Jan 4, 2023
rydeom
reviewed
Jan 4, 2023
rydeom
reviewed
Jan 4, 2023
# Conflicts: # .github/workflows/linux.yml # cmake/soro-server-client.cmake # web/client/index.html # web/client/utl/goldenLayoutHelper.js
julianharbarth
approved these changes
Jan 13, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the web client to use TypeScript, Vue.js, VueX and NPM. It thus enhances the development and production deployment experience for the webclient as before just about plain javascript was used.
Having installed npm, the setup and starting the HMR dev-server is rather easy:
Production deployment gets a whole lot easier too:
The bulk load of this PR is the
package-lock.json(abt 5000 lines) and the removal of the hardcoded dependencies. The following packages got upgraded with this PR:This PR also disables clearing the cache, as it was not usable before the PR too. Trying the clear the cache resulted in an error, so it was disabled:
Closes #4