-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webargs 8 #112
Webargs 8 #112
Conversation
…defined unknown field behavior
…tead of query for consistency
…ix test_register_route_for_relative_url function
webargs / apispec maintainer, here. When publishing a major webargs/apispec version, we generally drop support for the old one right away. But the migration is generally painless. webargs was an exception to this and I think we maintained 5.x for a little while. Anyway, my point is go ahead and drop every non latest major version of webargs/apispec anytime. The former versions are unmaintained and it shouldn't bother anyone. |
@lafrech, thanks for the recommendation! I will drop all non latest versions of webargs and apispec soon. |
Fixes #111
Relevant changes from webargs 5.x to 8.1:
Changes to aiohttp-apispec:
locations
args to tolocation
.location
kwargs backwards compatibility.test_register_route_for_relative_url()
.****Recommended TODO item to add ability to set an unknown behavior override for validation middleware. Just need to inject another argument to request body i.e., schema['unknown'] for parser to override unknown behavior defined in marshmallow schema.
**Since bumping webargs to >= 8.0.1 drops marshmallow 2 support, we should also consider bumping apispec to >=4.
***
test_register_route_for_relative_url()
was passing locally but failing in the pipeline. Upon closer inspection it looks like the assertion was incorrect. Addingurl
arg to setup should register a route so theroutes_count_after_setup_apispec
should not equal toroutes_count
before setup. Indeed after relevant fixes the test function is now passing both locally and should pass in CICD pipeline.