isolate underway migrations #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxcountryman
force-pushed
the
migration-isolation
branch
6 times, most recently
from
95badb9
to
a3df409
Compare
This is something of a hack to work around the fact that SQLx migrations do not currently support specifying a schema under which the migrations table will live. Here we provide a search path throughout our migrations and in the transaction that will run the migrations to ensure that migrations are applied to `underway._sqlx_migrations`. Note that this assumes a `public._sqlx_migrations` exists. In the future we should be able to use `sqlx.toml` to address this more robustly. That's expected as part of the `0.9.0` release of SQLx. Please see: launchbadge/sqlx#3383 Closes #11
maxcountryman
force-pushed
the
migration-isolation
branch
from
a3df409
to
f66a3b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something of a hack to work around the fact that SQLx migrations do not currently support specifying a schema under which the migrations table will live.
Here we provide a search path throughout our migrations and in the transaction that will run the migrations to ensure that migrations are applied to
underway._sqlx_migrations. Note that this assumes apublic._sqlx_migrationsexists.In the future we should be able to use
sqlx.tomlto address this more robustly. That's expected as part of the0.9.0release of SQLx. Please see: launchbadge/sqlx#3383Closes #11