Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default to id if provider_id is missing for resource.id #1

Conversation

maxcold
Copy link
Owner

@maxcold maxcold commented Oct 16, 2024

Proposed commit message

Ensuring resource.id is set for Cloud Configuration Finding data stream by defaulting to resource.id from the source data when resource.provider_id is missing

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Run pipeline tests elastic-package test pipeline --data-streams cloud_configuration_finding

Related issues

Screenshots

@maxcold maxcold added the enhancement New feature or request label Oct 16, 2024
@maxcold
Copy link
Owner Author

maxcold commented Oct 18, 2024

Included in elastic#11414

@maxcold maxcold closed this Oct 18, 2024
@maxcold maxcold deleted the csp-wiz-always-provide-resource-id branch October 18, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant