Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite by amaanq #13

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

rewrite by amaanq #13

wants to merge 1 commit into from

Conversation

max397574
Copy link
Owner

Hello @amaanq doing this like this because I couldn't open an issue in your repo to ask
Do you plan to eventually merge your rewrite into this repo or do you want to maintain your own fork?
Because even though it might seemed like this, this repo isn't unmaintained. I just didn't really have time to work on this thing since the last months I was really busy with other things apart from FOSS in my life. But soon things should become a bit more calm and I planned to return to this project since I also got quite a bit better at rust since I wrote this.

I'd be really happy to accept a pull request from you.

@amaanq
Copy link
Collaborator

amaanq commented Jul 27, 2023

Hi! I was playing around with this for upstream to be able to leverage a fully working formatter but found the logic a bit too bare, so at this point I am doing a full rewrite. Once I was somewhat done I was going to open a mock PR just to ask something, but you're ahead of me!

Do you mind allowing me to upstream this repo to tree-sitter? Of course you would have credit for kicking it off, but having the repo in a "more official" place is "more better" - no feelings hurt if that displeases you

@max397574
Copy link
Owner Author

I don't mind at all upstreaming this to tree-sitter
I can add you as contributor so you can do this since you're a member of the org.

@amaanq
Copy link
Collaborator

amaanq commented Jul 27, 2023

great, thanks!

@max397574
Copy link
Owner Author

Anything else I have to do so you can move this into the org?

@amaanq
Copy link
Collaborator

amaanq commented Jul 27, 2023

I think maybe I would need ownership access or have the repo transferred to me (and then I can transfer it to tree-sitter myself), but first let me double check with maxbrunsfeld, if he's totally against it then it'll go to nvim-treesitter (but of course tree-sitter org is preferred)

@max397574
Copy link
Owner Author

it seems like you can only give ownership access when the repo is in an org
so ig the easiest way is if I just either transfer it to tree-sitter directly (idk if that's possible) or I transfer it to you and then you move it to tree-sitter and readd me as colaborator

@amaanq
Copy link
Collaborator

amaanq commented Jul 27, 2023

That sounds good

@max397574
Copy link
Owner Author

image

@amaanq
Copy link
Collaborator

amaanq commented Jul 28, 2023

Ah I see, let's wait for Max's thoughts on moving it to upstream first (but tbh I'm sure he wouldn't mind)

@max397574
Copy link
Owner Author

@amaanq any updates on this?

@amaanq
Copy link
Collaborator

amaanq commented Nov 7, 2023

Yep, I have approval to upstream this - I have some decent progress locally but definitely nowhere near complete - I'll let you know when I'd like to move it upstream (probably within a month, just really busy rn)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants