Improve error message on file write error (mitsuhiko#631)

Will help to diagnose mitsuhiko#621
max-sixty · Oct 1, 2024 · 916eed7 · 916eed7
1 parent 9c75613
commit 916eed7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/insta/src/content/mod.rs b/insta/src/content/mod.rs
@@ -24,7 +24,6 @@ pub enum Error {
     UnexpectedDataType,
     #[cfg(feature = "_cargo_insta_internal")]
     MissingField,
-    #[cfg(feature = "_cargo_insta_internal")]
     FileIo(std::io::Error, std::path::PathBuf),
 }
 
@@ -39,7 +38,6 @@ impl fmt::Display for Error {
             }
             #[cfg(feature = "_cargo_insta_internal")]
             Error::MissingField => f.write_str("A required field was missing"),
-            #[cfg(feature = "_cargo_insta_internal")]
             Error::FileIo(e, p) => {
                 f.write_str(format!("File error for {:?}: {}", p.display(), e).as_str())
             }

diff --git a/insta/src/snapshot.rs b/insta/src/snapshot.rs
@@ -491,7 +491,8 @@ impl Snapshot {
         }
 
         let serialized_snapshot = self.serialize_snapshot(md);
-        fs::write(path, serialized_snapshot)?;
+        fs::write(path, serialized_snapshot)
+            .map_err(|e| content::Error::FileIo(e, path.to_path_buf()))?;
         Ok(())
     }