Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using deprecated Buffer constructor #142

Merged
merged 1 commit into from
Mar 3, 2018

Conversation

ChALkeR
Copy link
Contributor

@ChALkeR ChALkeR commented Mar 2, 2018

safe-buffer is already used and provides Buffer.from polyfill, so just use Buffer.from directly to avoid hitting deprecated API.

Refs: https://nodejs.org/api/deprecations.html#deprecations_dep0005_buffer_constructor

Tracking: nodejs/node#19079

This was overlooked in c9312bd.

/cc @mcollina

safe-buffer is already used and provides Buffer.from polyfill,
so just use Buffer.from directly to avoid hitting deprecated API.

Refs:
https://nodejs.org/api/deprecations.html#deprecations_dep0005_buffer_constructor
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit aa3f04b into max-mapper:master Mar 3, 2018
@mcollina
Copy link
Collaborator

mcollina commented Mar 3, 2018

Thanks, released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants