Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change introduced in 3.1.0 -> ~3.2.0 #39

Open
bcomnes opened this issue Aug 8, 2019 · 1 comment
Open

Breaking change introduced in 3.1.0 -> ~3.2.0 #39

bcomnes opened this issue Aug 8, 2019 · 1 comment

Comments

@bcomnes
Copy link
Contributor

bcomnes commented Aug 8, 2019

In https://github.com/maxogden/abstract-blob-store/pull/31/files#diff-f763f1634ff40f723dd8de924120ce55R60 a new test was added to check for the presence of err.notFound on blobs that aren't found and released as semver minor. I believe this to be a semver mistake, as its breaking downstream blob store tests in non-breaking semver ranges.

What should be done:

  • Skip the t.ok(e.notFound, 'error reports not found') test and release as a patch release in 3.0.0 major family.
  • Document the error.notFound = true property in the spec and re-add the test and release as 4.0.0 with release notes regarding the change.
bcomnes added a commit to bcomnes/abstract-blob-store that referenced this issue Aug 8, 2019
See max-mapper#39 for ideas to a resolution of this issue.
mafintosh pushed a commit that referenced this issue Aug 8, 2019
See #39 for ideas to a resolution of this issue.
@bcomnes
Copy link
Contributor Author

bcomnes commented Aug 8, 2019

Ok, the immediate issue is fixed #40

The test suite is no longer breaking due to the test of a previously unspecified error properties.

The next question is, do we spec that and include it in a major revision. This kind of thing seems like it may be the concern of the concrete implementations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant