Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disappearing loiter circles #12033

Merged

Conversation

gillamkid
Copy link
Contributor

Description

When video streaming was enabled, toggling between mini video and full screen video mode would make the circles representing loiter circles on the flight path disappear. This PR fixes that issue.

Steps to Reproduce

  1. open a PX4 plane sim. ex
cd PX4-Autopilot
make px4_sitl gazebo-classic_plane_lidar
  1. Open QGC daily

  2. create a mission with a loiter waypoint.
    make-mission

  3. upload the mission to the vehicle and go to Fly view
    before-toggle

  4. switch to big video mode
    big-video

  5. switch back to Big map mode
    after-toggle
    Notice how the loiter circle has collapsed. This is the bug that is fixed. With the fix in this PR the loiter circle properly reappears when toggling the video from mini to full screen.

Sponsor

This contribution was sponsored by Firestorm
654d4f9476ff2a38f37e9ab9_firestorm-homepage-share-img-2

When video streaming was enabled, toggling between mini
video and full screen video mode would make the circles
representing loiter circles on the flight path disappear. This
fixes that issue.
@DonLakeFlyer
Copy link
Contributor

Great, thanks so much

@DonLakeFlyer DonLakeFlyer merged commit 982da35 into mavlink:master Oct 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants