Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AudioOutput: Improvements #11342

Merged
merged 1 commit into from
Apr 17, 2024
Merged

AudioOutput: Improvements #11342

merged 1 commit into from
Apr 17, 2024

Conversation

HTRamsey
Copy link
Collaborator

@HTRamsey HTRamsey commented Apr 16, 2024

Modernizes AudioOutput with new functionality from Qt6.6.

  • The queue is now handled internally in the QTextToSpeech object.
  • Now available to use from QML.
  • No longer dependent on QGCApplication making it an isolated utility available everywhere with a singleton using static methods.
  • Inherits from QTextToSpeech making all functions available.
  • Makes use of a QHash for faster translations
  • Uses InvokeMethod for thread safety

{ "COMPID", "component eye dee" },
{ "params", "parameters" },
{ "id", "eye dee" },
{ "ADSB", "Hey Dee Ess Bee" },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one seems a little odd: "Hey" for "A". Isn't that wrong? Might as well fix that.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked with espeak on linux and I think you can just do "A.D.S.B.", "I.D.", "E.K.F.", etc. I don't know if that's standard though

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MockLink has a "send status text" option which you could hack into and change the one that is spoken to test it out. I can test it on Mac.

https://github.com/mavlink/qgroundcontrol/blob/master/src/comm/MockLink.cc#L1377

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified that "A.D.S.B" is spoken correctly on the Mac. I had to change the MAV_SEVERITY_NOTICE text in MockLink to test. The "#" status text isn't causing it to talk for some reason. Not sure if there is a bug there, I'll look.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also works on Android, so I guess we can try that to simplify things and if anybody has any issues we can change it back

@HTRamsey HTRamsey merged commit 9be4498 into mavlink:master Apr 17, 2024
8 checks passed
@HTRamsey HTRamsey deleted the dev-audio branch April 17, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants