-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AudioOutput: Improvements #11342
AudioOutput: Improvements #11342
Conversation
src/Audio/AudioOutput.cc
Outdated
{ "COMPID", "component eye dee" }, | ||
{ "params", "parameters" }, | ||
{ "id", "eye dee" }, | ||
{ "ADSB", "Hey Dee Ess Bee" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one seems a little odd: "Hey" for "A". Isn't that wrong? Might as well fix that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked with espeak on linux and I think you can just do "A.D.S.B.", "I.D.", "E.K.F.", etc. I don't know if that's standard though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MockLink has a "send status text" option which you could hack into and change the one that is spoken to test it out. I can test it on Mac.
https://github.com/mavlink/qgroundcontrol/blob/master/src/comm/MockLink.cc#L1377
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified that "A.D.S.B" is spoken correctly on the Mac. I had to change the MAV_SEVERITY_NOTICE text in MockLink to test. The "#" status text isn't causing it to talk for some reason. Not sure if there is a bug there, I'll look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It also works on Android, so I guess we can try that to simplify things and if anybody has any issues we can change it back
Modernizes AudioOutput with new functionality from Qt6.6.