Android: Update Serial Implementation #11082
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTRamsey
force-pushed
the
dev-android-serial
branch
from
cabd653
to
820edaa
Compare
HTRamsey
changed the title
|
Following this. Willing to test on our custom Android-based RC controllers. |
HTRamsey
force-pushed
the
dev-android-serial
branch
2 times, most recently
from
583a175
to
322ebc2
Compare
|
Is this just a goal of better repo organization as well? Or are there functionals changes here as well? |
|
The biggest change will be much better USB support (easier for people to add support for new devices too). The cleanup is a consequence of me replacing the dated custom QSerialPort implementation and custom implementation of the usb library with a simplified interface. Although I did move a couple files around just to better structure the android packaging. |
HTRamsey
force-pushed
the
dev-android-serial
branch
from
9b927d0
to
5bdf564
Compare
|
Oh, ok. That's all great stuff. |
|
It will be a little easier if I can get us switched to CMake entirely first, so that I don't have to update both build systems. I will return to this later. |
HTRamsey
force-pushed
the
dev-android-serial
branch
3 times, most recently
from
653f9b7
to
f41ebdc
Compare
HTRamsey
force-pushed
the
dev-android-serial
branch
from
f41ebdc
to
3bea2ad
Compare
HTRamsey
force-pushed
the
dev-android-serial
branch
from
3bea2ad
to
80350ac
Compare
HTRamsey
changed the title
HTRamsey
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@DonLakeFlyer I am just making this public in case you have comments. This will probably take a bit of time to finish. I can break it down into multiple PRs when I am done.