Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[camera plugin] Fix image_index and capture_result not properly filled #1923

Merged
merged 1 commit into from
Nov 14, 2023
Merged

[camera plugin] Fix image_index and capture_result not properly filled #1923

merged 1 commit into from
Nov 14, 2023

Conversation

ghost
Copy link

@ghost ghost commented Nov 14, 2023

Problem Solved

Both image_index and capture_result fields of the mavros_msgs::CameraImageCaptured were left unassigned.

Proposed Solution

Assign the proper values to them according to the CAMERA_IMAGE_CAPTURED message

vooon
vooon approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@vooon vooon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@vooon vooon added this to the Version 1.18 milestone Nov 14, 2023
@vooon vooon merged commit 92e4062 into mavlink:master Nov 14, 2023
3 checks passed
@ghost ghost deleted the pr-fix-camera_image_captured-plugin branch November 14, 2023 16:58
@ghost ghost restored the pr-fix-camera_image_captured-plugin branch November 14, 2023 16:59
@ghost ghost deleted the pr-fix-camera_image_captured-plugin branch November 14, 2023 17:00
@ghost ghost mentioned this pull request Nov 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
extras fix
Projects
None yet
Milestone
Version 1.18
Development

Successfully merging this pull request may close these issues.
2 participants
@vooon @beniaminopozzan