Change connection CLI, add TCP server connections #2342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianoes
force-pushed
the
pr-connection-cli
branch
from
6111cc1
to
1775cdd
Compare
julianoes
force-pushed
the
pr-connection-cli
branch
3 times, most recently
from
5b8468a
to
fea313c
Compare
This removes the add_udp/tcp/serial_connection and instead switches to only add_any_connection. Also, we now encourage the use of udpin and udpout instead of udp only to make it clear what is connecting like a client or server.
A bit less duplication like this.
Rename the file and class, so that we can add a TCP server connection as well.
We only do accept() again once we had an error and need to re-connect.
julianoes
force-pushed
the
pr-connection-cli
branch
from
fea313c
to
b74706e
Compare
|
|
@JonasVautherin any objections? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the connection CLI:
udp://IP:PORTtoudpout://IP:PORTudp://:PORTtoudpin://0.0.0.0:PORTwhich should make the usage easier.
Also, the baudrate for serial connection is now mandatory, to avoid confusing implicit defaults.
Additionally, this PR implements TCP as a server and not just client.
Closes #2315.