[RELEASE v1.4] Backport disable -ffast-math for iOS #2177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasDebrunner
force-pushed
the
1.4-ios-no-fast-math
branch
4 times, most recently
from
c548300 to
f18e239
Compare
JonasVautherin
requested changes
Nov 16, 2023
|
@JonasVautherin for v1.4 I would be ok just patching the one option. If we update the full toolchain here, we introduce more risk and churn. |
|
@julianoes: good point, fine for me then 👍 |
julianoes
force-pushed
the
1.4-ios-no-fast-math
branch
from
f18e239 to
020af7f
Compare
|
Rebased and force-pushed. |
julianoes
approved these changes
Nov 28, 2023
JonasVautherin
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #2176
CI seems to fail, since macOS runners come with Python 3.12, which break the mavlink generators