-
-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Winch and Gripper plugins #1958
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 20, 2023
potaito
force-pushed
the
winch_plugin
branch
3 times, most recently
from
January 31, 2023 13:04
2c4c82c
to
9a679f1
Compare
JonasVautherin
previously approved these changes
Jan 31, 2023
JonasVautherin
previously approved these changes
Feb 1, 2023
JonasVautherin
requested changes
Feb 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could have anticipated the same problem in gripper_impl.cpp
🙈
JonasVautherin
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs
Description
Allows winch and gripper control via MAVSDK using the messages
Winches and grippers are supposed to send out a heartbeat. I only added knowledge of the winch heartbeat to
system_impl.cpp
, since grippers don't have their own MAV_TYPE, and I think we are assuming that grippers and winches can be the same device actually. Other than that the HEARTBEAT is ignored, and only WINCH_STATUS is parsed.Tests done:
I don't know how to quickly test status messages to verify that the implementation is working.
Please don't merge before I squashed the commits