Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Winch and Gripper plugins #1958

Merged
merged 5 commits into from
Feb 1, 2023
Merged

Conversation

potaito
Copy link
Contributor

@potaito potaito commented Jan 20, 2023

Related PRs

Description

Allows winch and gripper control via MAVSDK using the messages

  • MAV_CMD_DO_GRIPPER (211)
  • MAV_CMD_DO_WINCH (42600 )

Winches and grippers are supposed to send out a heartbeat. I only added knowledge of the winch heartbeat to system_impl.cpp, since grippers don't have their own MAV_TYPE, and I think we are assuming that grippers and winches can be the same device actually. Other than that the HEARTBEAT is ignored, and only WINCH_STATUS is parsed.

Tests done:

  • Controlling a gripper, mock script and real device
  • Controlling a winch, mock script and real device
  • Subscribing to winch status messages

I don't know how to quickly test status messages to verify that the implementation is working.

Please don't merge before I squashed the commits

@potaito potaito marked this pull request as draft January 20, 2023 10:42
@potaito potaito force-pushed the winch_plugin branch 3 times, most recently from 2c4c82c to 9a679f1 Compare January 31, 2023 13:04
JonasVautherin
JonasVautherin previously approved these changes Jan 31, 2023
src/mavsdk/plugins/gripper/gripper_impl.cpp Show resolved Hide resolved
JonasVautherin
JonasVautherin previously approved these changes Feb 1, 2023
Copy link
Collaborator

@JonasVautherin JonasVautherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could have anticipated the same problem in gripper_impl.cpp 🙈

src/mavsdk/plugins/gripper/gripper_impl.cpp Outdated Show resolved Hide resolved
src/mavsdk/plugins/gripper/gripper_impl.cpp Outdated Show resolved Hide resolved
@potaito potaito marked this pull request as ready for review February 1, 2023 14:15
@JonasVautherin JonasVautherin merged commit bf57177 into mavlink:main Feb 1, 2023
@potaito potaito deleted the winch_plugin branch February 1, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants