[IE-673] Update api errors handling #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Nate Perry <[email protected]>
Co-authored-by: Nate Perry <[email protected]>
Co-authored-by: Nate Perry <[email protected]>
Co-authored-by: Nate Perry <[email protected]>
Co-authored-by: Nate Perry <[email protected]>
b6b
approved these changes
Jun 6, 2024
| @@ -10,15 +12,39 @@ def on_complete(env) | |||
| private | |||
|
|
|||
| def raise_http_errors(code, body) | |||
| return unless HTTP_RESPONSE_ERROR_RANGE.include?(code) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When one of our customers was running a scenario that relied on creating a survey some events were not being processed and were raising an
undefined methodmerge' for nil:NilClass`.This happened because the Qualtrics API is returning something other than the successful response the library relies on, and this response code was not listed under the
RequestErrorHandler, which should handle everything that is not a success.To make sure we will have all the information needed when any error messages are returned, we are adding all missing response errors to the handler.
Qualtrics Error Responses
** You have to click on the third
jsontab to see an example of an error response.Resolves
IE-673