IE-517 Ruby 3.0.6 Compatibility #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting in 2013, gem-ified standard library gems were only made available through Bundler if the gem was specified in the Gemfile, see: sferik/multi_xml#42 As a result we started to get the error: "No XML parser detected. If you're using Rubinius and Bundler, try adding an XML parser to your Gemfile (e.g. libxml-ruby, nokogiri, or rubysl-rexml). For more information, see sferik/multi_xml#42." To fix this issue we need to specify an xml parser in our Gemfile. We're not going to be doing that much work within an auth Gem, so performance of the xml parser doesn't matter that much. But we picked libxml for performance anyways. (https://medium.com/neuronio/generating-xml-in-ruby-builder-vs-nokogiri-vs-libxml-vs-ox-757ce2d8f83c)
…th gem maintenance
ncperry
commented
Feb 5, 2024
| @@ -1,5 +1,5 @@ | |||
| module OmniAuth | |||
| module Concur | |||
| VERSION = "0.0.1" | |||
| VERSION = "0.0.2" | |||
There was a problem hiding this comment.
This one is for you @wilkinsondesouza
There was a problem hiding this comment.
I appreciate that my rambling is being remembered 😄
ncperry
changed the title
wilkinsondesouza
approved these changes
Feb 5, 2024
| @@ -1,5 +1,5 @@ | |||
| module OmniAuth | |||
| module Concur | |||
| VERSION = "0.0.1" | |||
| VERSION = "0.0.2" | |||
There was a problem hiding this comment.
I appreciate that my rambling is being remembered 😄
dezkowalski
approved these changes
Feb 5, 2024
ncperry
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make Ruby 3 compatible we had to:
For CI and maintenance we:
https://kantata.atlassian.net/browse/IE-517