Closes mozilla-mobile#27209: fix WallpapersSettings crash

mavduevskiy · Sep 29, 2022 · e42693e · e42693e
1 parent 1005412
commit e42693e
Showing 1 changed file with 13 additions and 2 deletions.
diff --git a/app/src/main/java/org/mozilla/fenix/settings/wallpaper/WallpaperSettingsFragment.kt b/app/src/main/java/org/mozilla/fenix/settings/wallpaper/WallpaperSettingsFragment.kt
@@ -37,6 +37,8 @@ class WallpaperSettingsFragment : Fragment() {
         requireComponents.useCases.wallpaperUseCases
     }
 
+    private var snackBar: FenixSnackbar? = null
+
     override fun onCreateView(
         inflater: LayoutInflater,
         container: ViewGroup?,
@@ -106,8 +108,10 @@ class WallpaperSettingsFragment : Fragment() {
                     .setText(view.context.getString(R.string.wallpaper_updated_snackbar_message))
                     .setAction(requireContext().getString(R.string.wallpaper_updated_snackbar_action)) {
                         findNavController().navigate(R.id.homeFragment)
+                    }.also { snackBar ->
+                        this.snackBar = snackBar
+                        snackBar.show()
                     }
-                    .show()
 
                 Wallpapers.wallpaperSelected.record(
                     Wallpapers.WallpaperSelectedExtra(
@@ -128,8 +132,10 @@ class WallpaperSettingsFragment : Fragment() {
                             val retryResult = wallpaperUseCases.selectWallpaper(wallpaper)
                             onWallpaperSelected(wallpaper, retryResult, view)
                         }
+                    }.also { snackBar ->
+                        this.snackBar = snackBar
+                        snackBar.show()
                     }
-                    .show()
             }
             else -> { /* noop */ }
         }
@@ -139,4 +145,9 @@ class WallpaperSettingsFragment : Fragment() {
         super.onResume()
         showToolbar(getString(R.string.customize_wallpapers))
     }
+
+    override fun onStop() {
+        super.onStop()
+        snackBar?.let { it.dismiss() }
+    }
 }