Bridge some matrix stickers as telegram stickers #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With maunium/stickerpicker#49 applied, Element Desktop users send enough information about telegram-imported stickers to bridge them as regular telegram stickers. This commit has a few caveats, most notably it only works with sticker sets that are currently added to the user’s telegram account, and it doesn’t cache either the sticker sets or the stickers within these sets. However I haven’t noticed any performance issues due to this in my own testing over at chir.rs.
andersondinho1991
approved these changes
Dec 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With maunium/stickerpicker#49 applied, Element Desktop users send enough information about telegram-imported stickers to bridge them as regular telegram stickers.
This PR has a few caveats, most notably it only works with sticker sets that are currently added to the user’s telegram account, and it doesn’t cache either the sticker sets or the stickers within these sets.
However I haven’t noticed any performance issues due to this in my own testing over at chir.rs.