Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't no-op logouts #439

Closed
wants to merge 14 commits into from
Closed

Commits on Feb 14, 2024

  1. Don't no-op logouts

    Disconnect bridge users from their accounts on logout. This does not
    actually delete the Signal device being logged out of, though.
    AndrewFerr committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    bff1c61 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    998743f View commit details
    Browse the repository at this point in the history
  3. Refactor (*User).clearKeysAndDisconnect

    Pass it a context, and call it in fnDeleteSession
    AndrewFerr committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    90756b9 View commit details
    Browse the repository at this point in the history
  4. Log disconnect errors

    AndrewFerr committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    5145d15 View commit details
    Browse the repository at this point in the history
  5. Refactor (*User).Logout

    Treat a failure to delete the device from the store as fatal, because
    otherwise credentials would remain in the store & might be reused
    accidentally on the next read from the store (like on bridge restart).
    AndrewFerr committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    a642d9e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e871389 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    a3a7932 View commit details
    Browse the repository at this point in the history
  8. Reuse client on re-login

    AndrewFerr committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    239b2bb View commit details
    Browse the repository at this point in the history
  9. Remove "was once logged in" ping response

    as the condition for this response has false positives
    AndrewFerr committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    fdfc4a3 View commit details
    Browse the repository at this point in the history
  10. Try to be more careful clearing state on logout

    Make logouts delete the device from the database (not just clear
    sessions and keys) and update the users store & user-to-uuid map.
    AndrewFerr committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    2d77e28 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    ff16ef4 View commit details
    Browse the repository at this point in the history
  12. Check for nil

    AndrewFerr committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    af42a50 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    5bb8427 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2024

  1. Configuration menu
    Copy the full SHA
    0cd9c9f View commit details
    Browse the repository at this point in the history