-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't no-op logouts #439
Closed
Closed
Don't no-op logouts #439
Commits on Feb 14, 2024
-
Disconnect bridge users from their accounts on logout. This does not actually delete the Signal device being logged out of, though.
Configuration menu - View commit details
-
Copy full SHA for bff1c61 - Browse repository at this point
Copy the full SHA bff1c61View commit details -
Configuration menu - View commit details
-
Copy full SHA for 998743f - Browse repository at this point
Copy the full SHA 998743fView commit details -
Refactor (*User).clearKeysAndDisconnect
Pass it a context, and call it in fnDeleteSession
Configuration menu - View commit details
-
Copy full SHA for 90756b9 - Browse repository at this point
Copy the full SHA 90756b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5145d15 - Browse repository at this point
Copy the full SHA 5145d15View commit details -
Treat a failure to delete the device from the store as fatal, because otherwise credentials would remain in the store & might be reused accidentally on the next read from the store (like on bridge restart).
Configuration menu - View commit details
-
Copy full SHA for a642d9e - Browse repository at this point
Copy the full SHA a642d9eView commit details -
Configuration menu - View commit details
-
Copy full SHA for e871389 - Browse repository at this point
Copy the full SHA e871389View commit details -
Configuration menu - View commit details
-
Copy full SHA for a3a7932 - Browse repository at this point
Copy the full SHA a3a7932View commit details -
Configuration menu - View commit details
-
Copy full SHA for 239b2bb - Browse repository at this point
Copy the full SHA 239b2bbView commit details -
Remove "was once logged in" ping response
as the condition for this response has false positives
Configuration menu - View commit details
-
Copy full SHA for fdfc4a3 - Browse repository at this point
Copy the full SHA fdfc4a3View commit details -
Try to be more careful clearing state on logout
Make logouts delete the device from the database (not just clear sessions and keys) and update the users store & user-to-uuid map.
Configuration menu - View commit details
-
Copy full SHA for 2d77e28 - Browse repository at this point
Copy the full SHA 2d77e28View commit details -
Configuration menu - View commit details
-
Copy full SHA for ff16ef4 - Browse repository at this point
Copy the full SHA ff16ef4View commit details -
Configuration menu - View commit details
-
Copy full SHA for af42a50 - Browse repository at this point
Copy the full SHA af42a50View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5bb8427 - Browse repository at this point
Copy the full SHA 5bb8427View commit details
Commits on Feb 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0cd9c9f - Browse repository at this point
Copy the full SHA 0cd9c9fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.