Support MSC2530 fields in media event types #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frebib
added a commit
to frebib/maubot-xkcd
that referenced
this pull request
Mar 22, 2024
Required until mautrix/python#170 is merged and pulled into maubot. Signed-off-by: Joe Groocock <[email protected]>
tulir
reviewed
Mar 22, 2024
|
Much simpler |
|
Oh, I'm gonna have to reorder a few bits to make this one, please hold |
Add `filename`, `format` and `formatted_body` to media event content types. Signed-off-by: Joe Groocock <[email protected]>
Python 3.11.6 (main, Oct 8 2023, 05:06:43) [GCC 13.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from mautrix.types import Format, MediaMessageEventContent
>>> MediaMessageEventContent(filename="aaa.jpg", body="aaa", format=Format.HTML, formatted_body="aaa").serialize()
{'body': 'aaa', 'format': 'org.matrix.custom.html', 'formatted_body': 'aaa', 'filename': 'aaa.jpg'} |
tulir
approved these changes
Mar 22, 2024
frebib
added a commit
to frebib/maubot-xkcd
that referenced
this pull request
Mar 22, 2024
Required until mautrix/python#170 is merged and pulled into maubot. Signed-off-by: Joe Groocock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
filename,formatandformatted_bodyto media event content types.