Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove LinkedIn from core #12147

Merged
merged 4 commits into from
Apr 11, 2023
Merged

Remove LinkedIn from core #12147

merged 4 commits into from
Apr 11, 2023

Conversation

kuzmany
Copy link
Member

@kuzmany kuzmany commented Mar 30, 2023

Q A
Bug fix? (use the a.b branch) [ ]
New feature/enhancement? (use the a.x branch) [ ]
Deprecations? [ ]
BC breaks? (use the c.x branch) [ ]
Automated tests included? [ ]
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes #...

Description:

Based on #8895 LinkedIn API not working anymore. Let's remove and any company can pick it, build based on IntegrationBundle and the put to marketplace

Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)

@kuzmany kuzmany added the ready-to-test PR's that are ready to test label Mar 30, 2023
@cla-bot cla-bot bot added the cla-signed The PR contributors have signed the contributors agreement label Mar 30, 2023
@RCheesley
Copy link
Member

Please take a look at the conflict @kuzmany

@RCheesley RCheesley added the has-conflicts Pull requests that cannot be merged until conflicts have been resolved label Mar 30, 2023
@mabumusa1 mabumusa1 self-requested a review March 30, 2023 08:55
@mabumusa1
Copy link
Member

Thanks @kuzmany , I would vote for the removal of anything that is not supported anymore. I will review as soon as you are done with this PR

@RCheesley RCheesley mentioned this pull request Mar 30, 2023
Closed
54 tasks
@RCheesley RCheesley marked this pull request as draft April 4, 2023 17:15
@RCheesley
Copy link
Member

I have set this back to draft while the conflicts are resolved so it doesn't confuse folks.

@kuzmany kuzmany marked this pull request as ready for review April 7, 2023 04:57
@kuzmany kuzmany removed the has-conflicts Pull requests that cannot be merged until conflicts have been resolved label Apr 7, 2023
@codecov
Copy link

codecov bot commented Apr 7, 2023 •
edited
Loading

Codecov Report

Merging #12147 (21994fd) into 5.x (0c6cbc8) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                5.x   #12147      +/-   ##
============================================
+ Coverage     55.46%   55.48%   +0.02%     
+ Complexity    35922    35902      -20     
============================================
  Files          2259     2257       -2     
  Lines        107706   107651      -55     
============================================
- Hits          59734    59733       -1     
+ Misses        47972    47918      -54
Impacted Files Coverage Δ
...SocialBundle/Command/MonitorTwitterBaseCommand.php 23.15% <ø> (ø)

... and 1 file with indirect coverage changes

mabumusa1
mabumusa1 approved these changes Apr 9, 2023
View reviewed changes
Copy link
Member

@mabumusa1 mabumusa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are good. let's merge it

@mabumusa1 mabumusa1 added T1 Low difficulty to fix (issue) or test (PR) code-review-needed PR's that require a code review before merging mautic-5 Relates to Mautic 5.x and removed ready-to-test PR's that are ready to test labels Apr 9, 2023
@mabumusa1 mabumusa1 added this to the 5.0-alpha milestone Apr 9, 2023
escopecz
escopecz approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thanks! 👍

@escopecz escopecz merged commit d1d1920 into mautic:5.x Apr 11, 2023
@escopecz escopecz added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged bc-break A BC break PR for major release milestones only plugin Anything related to plugins and removed code-review-needed PR's that require a code review before merging labels Apr 11, 2023
@escopecz escopecz added the bug Issues or PR's relating to bugs label Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escopecz escopecz escopecz approved these changes

@mabumusa1 mabumusa1 mabumusa1 approved these changes

Assignees

@kuzmany kuzmany

Labels
bc-break A BC break PR for major release milestones only bug Issues or PR's relating to bugs cla-signed The PR contributors have signed the contributors agreement mautic-5 Relates to Mautic 5.x plugin Anything related to plugins ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged T1 Low difficulty to fix (issue) or test (PR)
Projects
None yet
Milestone
5.0-alpha
Development

Successfully merging this pull request may close these issues.
4 participants
@kuzmany @RCheesley @mabumusa1 @escopecz