Use default mautic/mautic branch instead of features
#271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RCheesley
approved these changes
May 4, 2022
There was a problem hiding this comment.
DOH! 🤦♀️ Thanks @dennisameling makes sense to use the default branch indeed!
|
I think we're good to merge given that we know there are some things which are broken & need fixing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API tests have been running against the
featuresbranch all this time 🤦🏼♂️ let's simply test against the default branch moving forward (which is 4.x at the time of writing, but will change eventually).CI will obviously fail on this one because lots of changes were introduced in Mautic in the meantime.