Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug related to using json_encode instead of http_build_query #216

Closed
ghost opened this issue May 9, 2020 · 2 comments
Closed

Bug related to using json_encode instead of http_build_query #216

ghost opened this issue May 9, 2020 · 2 comments

Comments

@ghost
Copy link

ghost commented May 9, 2020

Using json_encode instead of http_build_query works nicely with Basic Auth with both POST and GET but for Oauth2 only GET works.. so if you tried to create a contact using Oauth you will get this error

errors: { 0: { code: "401", message: "The response has unexpected status code (401)." }
wise-gorilla added a commit to wise-gorilla/api-library that referenced this issue May 13, 2020
@wise-gorilla
Fix OAuth Authorization
af9bfa1 
This edit fix the oAuth issue that raised when changed the POST to use  json_encode instead of http_build_query mautic#216
@wise-gorilla wise-gorilla mentioned this issue May 13, 2020
Merged
@benlumley
Copy link

This fix works for me + should be merged...

@dennisameling
Copy link
Member

Fixed in #217 which has now been merged. Thanks for reporting this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benlumley @dennisameling