fix locationService treating success as errors #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you!. Obviously there is a bug in post location response handling. Will merge. |
mauron85
reviewed
Sep 7, 2018
| @@ -629,9 +629,11 @@ private boolean postLocation(BackgroundLocation location) { | |||
| if (mListener != null) | |||
| mListener.onRequestedAbortUpdates(); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
can you please remove this redundant space?
|
Merged! Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm using cordova-plugin-background-geolocation and getting a warning after location post:
Is the message and return following this comparison right?
background-geolocation-android/src/main/java/com/marianhello/bgloc/LocationService.java
Line 634 in a9eb831
If the status code is 200 and, as stated, it's correct. Should'nt it return true, then the location would be deleted? Also, shouldn't the log message be positive?
The location is being saved as pending location even though the post worked (200/):
background-geolocation-android/src/main/java/com/marianhello/bgloc/LocationService.java
Line 580 in a9eb831
fix #12