Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CTRL+S save shortcut #66

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Add CTRL+S save shortcut #66

merged 1 commit into from
Aug 28, 2024

Conversation

luk1337
Copy link
Contributor

@luk1337 luk1337 commented Aug 28, 2024

No description provided.

@matze
Copy link
Owner

matze commented Aug 28, 2024

Looks good, not sure if people will like having Ctrl-S being hijacked though. On the other hand, who saves web pages nowadays 🤷 … will give it a night to think about.

@luk1337
Copy link
Contributor Author

luk1337 commented Aug 28, 2024

Looks good, not sure if people will like having Ctrl-S being hijacked though. On the other hand, who saves web pages nowadays 🤷 … will give it a night to think about.

One can still save the webpage if they really desire, they just have to right click or focus on another element.

@matze
Copy link
Owner

matze commented Aug 28, 2024

Okay, okay, convinced :-)

@matze matze merged commit cbdc10a into matze:master Aug 28, 2024
1 check passed
@luk1337 luk1337 deleted the luk/ctrl_s branch August 28, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants